Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheer animation as a Note type #100

Closed

Conversation

Kiribartlett-Dev
Copy link

Originally, the cheer animation was the Play Animation event. This pull request shows that the cheer animation should be play as a note type instead of the Play Animation event.

2024-11-17.13-44-28.mp4

@Hundrec
Copy link
Collaborator

Hundrec commented Nov 18, 2024

Woo, PR 100!
I do like the idea of binding special animations like cheer to player inputs.
Good job!

@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Nov 19, 2024

Is there any noticeable benefit to using a note kind instead of just using the Play Animation Event?

@Hundrec
Copy link
Collaborator

Hundrec commented Nov 19, 2024

From my understanding, Boyfriend would now only cheer when you hit the bound note.
Also, it circumvents the bug where a note too close to an animation cancels that animation even if it's forced.

@AbnormalPoof
Copy link
Collaborator

If that's the case, then I feel like it'd be better to use something like a Play Animation note kind instead of making one specifically for cheer.

@Hundrec
Copy link
Collaborator

Hundrec commented Nov 19, 2024

Oh, is this PR not adding cheer to the list of note types alongside the weekend1 and mom singing notes?

That would indeed be ideal.

@AbnormalPoof
Copy link
Collaborator

AbnormalPoof commented Jan 22, 2025

This doesn't seem to do anything, could you clarify what this does?

@AbnormalPoof AbnormalPoof added type: enhancement Provides an enhancement or new feature. status: needs clarification Requires more info from the contributor. size: small A small pull request with 10 or fewer changes labels Jan 22, 2025
@amyspark-ng
Copy link

i think that rather than making a different note kind for every event in the game it would be better if we could make a note that triggered an event, so instead of Mom sings, and Heh pretty good being singular note types, you'd click an event-bound-note, so when the note is hit the event is called

@amyspark-ng
Copy link

also why is Heh pretty good a note kind? wouldn't it be better to just play an event that makes tankman play the animation?

@AbnormalPoof
Copy link
Collaborator

Closing this as all this does is add unnecessary code.

@AbnormalPoof AbnormalPoof added status: rejected PR did not pass review or cannot be approved. and removed type: enhancement Provides an enhancement or new feature. status: needs clarification Requires more info from the contributor. size: small A small pull request with 10 or fewer changes labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: rejected PR did not pass review or cannot be approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants