-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cheer animation as a Note type #100
Conversation
Woo, PR 100! |
Is there any noticeable benefit to using a note kind instead of just using the Play Animation Event? |
From my understanding, Boyfriend would now only cheer when you hit the bound note. |
If that's the case, then I feel like it'd be better to use something like a Play Animation note kind instead of making one specifically for cheer. |
Oh, is this PR not adding cheer to the list of note types alongside the weekend1 and mom singing notes? That would indeed be ideal. |
This doesn't seem to do anything, could you clarify what this does? |
i think that rather than making a different note kind for every event in the game it would be better if we could make a note that triggered an event, so instead of Mom sings, and Heh pretty good being singular note types, you'd click an event-bound-note, so when the note is hit the event is called |
also why is Heh pretty good a note kind? wouldn't it be better to just play an event that makes tankman play the animation? |
Closing this as all this does is add unnecessary code. |
Originally, the cheer animation was the Play Animation event. This pull request shows that the cheer animation should be play as a note type instead of the Play Animation event.
2024-11-17.13-44-28.mp4